update to bps.collect_while_completeing #536
Conversation
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
4 times, most recently
from
565b629
to
cbe0434
Compare
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
from
9703a49
to
5ddf953
Compare
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
from
5ddf953
to
923490c
Compare
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
2 times, most recently
from
db41573
to
be29b8e
Compare
| ) | ||
| yield from bps.wait(group=group) | ||
| done = yield from bps.wait(group=group, timeout=flush_period, move_on=True) | ||
| yield from bps.collect(*detectors, name=stream_name) |
There was a problem hiding this comment.
Is the removal of return_payload intentional?
There was a problem hiding this comment.
@evalott100 Yes this was intentional ..No data was getting generated when return_payload was False...I haven't tested this recently.. I will check and see if the behaviour is the same
There was a problem hiding this comment.
I have checked this today...This is working ... I'm able to collect data
There was a problem hiding this comment.
Can't see the full context for this since the github diff is cluttered with all the changes to main since this PR was opened. If you open a new PR after rebasing then add me as a reviewer 🙏
There was a problem hiding this comment.
I have created a new PR #691 because the branch go messed up...
ZohebShaikh
force-pushed
the
329-investigate-hanging-collect_while_completing-planstub
branch
from
3d148de
to
c90e403
Compare
ZohebShaikh
deleted the
329-investigate-hanging-collect_while_completing-planstub
branch
No description provided.